-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross chain swaps - tx submit #27262
Open
infiniteflower
wants to merge
88
commits into
mb891-fetch-bridge-quotes
Choose a base branch
from
mb892-cross-chain-swap-tx-submit
base: mb891-fetch-bridge-quotes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cross chain swaps - tx submit #27262
infiniteflower
wants to merge
88
commits into
mb891-fetch-bridge-quotes
from
mb892-cross-chain-swap-tx-submit
+5,784
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3 tasks
infiniteflower
changed the base branch from
develop
to
mb890-src-and-dest-asset-pickers-backup-0828
September 19, 2024 21:29
infiniteflower
changed the title
Mb892 cross chain swap tx submit
chore: cross chain swap tx submit
Sep 19, 2024
infiniteflower
force-pushed
the
mb892-cross-chain-swap-tx-submit
branch
from
October 1, 2024 18:33
325a70a
to
a6d627c
Compare
infiniteflower
changed the base branch from
mb890-src-and-dest-asset-pickers-backup-0828
to
mb890-src-and-dest-asset-pickers-backup-0927
October 1, 2024 18:33
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
2 times, most recently
from
October 2, 2024 00:33
448ce2a
to
4971d09
Compare
infiniteflower
force-pushed
the
mb892-cross-chain-swap-tx-submit
branch
from
October 2, 2024 20:43
b433f88
to
2813f63
Compare
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
from
October 2, 2024 23:34
4971d09
to
52f9352
Compare
infiniteflower
added a commit
to MetaMask/core
that referenced
this pull request
Oct 3, 2024
## Explanation <!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> This PR adds additional types to facilitate Bridge development in Extension. ## References <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? For example: * Fixes #12345 * Related to #67890 --> Related to: MetaMask/metamask-extension#27262 ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/transaction-controller` - ADDED: `bridgeApproval`, `bridge` types ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate --------- Co-authored-by: Matthew Walsh <[email protected]>
infiniteflower
force-pushed
the
mb892-cross-chain-swap-tx-submit
branch
from
October 3, 2024 18:45
3c283a7
to
94365a1
Compare
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
from
October 7, 2024 23:51
1ee57c2
to
81fbdf1
Compare
infiniteflower
force-pushed
the
mb892-cross-chain-swap-tx-submit
branch
from
October 8, 2024 20:27
a37617b
to
1d686bd
Compare
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
2 times, most recently
from
October 9, 2024 17:04
9f11057
to
7c2f8e0
Compare
infiniteflower
force-pushed
the
mb892-cross-chain-swap-tx-submit
branch
from
October 9, 2024 17:45
b0e3d32
to
d2d1d5a
Compare
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
from
October 9, 2024 18:03
7c2f8e0
to
3222e6d
Compare
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
from
October 9, 2024 18:22
3222e6d
to
6506bef
Compare
infiniteflower
force-pushed
the
mb892-cross-chain-swap-tx-submit
branch
from
October 9, 2024 18:56
d2d1d5a
to
6de5ea4
Compare
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
2 times, most recently
from
October 10, 2024 17:42
d80b1c6
to
75afeab
Compare
micaelae
reviewed
Oct 10, 2024
micaelae
force-pushed
the
mb890-src-and-dest-asset-pickers-backup-0927
branch
2 times, most recently
from
October 10, 2024 22:06
78bcf71
to
403d594
Compare
…uting to bridge page
…sLimit is inclusive of them already
infiniteflower
force-pushed
the
mb892-cross-chain-swap-tx-submit
branch
from
November 7, 2024 20:16
4c771c3
to
03a2f47
Compare
7 tasks
Builds ready [5ad9a16]
Page Load Metrics (1726 ± 61 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
micaelae
force-pushed
the
mb891-fetch-bridge-quotes
branch
from
November 9, 2024 00:40
a8d45e0
to
1a77d8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following:
Does not fully:
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2024-11-08.at.11.06.12.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist